Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creative Tech Events #1653

Merged
merged 6 commits into from
Jan 21, 2020
Merged

Add Creative Tech Events #1653

merged 6 commits into from
Jan 21, 2020

Conversation

danvoyce
Copy link
Contributor

@danvoyce danvoyce commented Nov 8, 2019

https://github.com/danvoyce/awesome-creative-tech-events/tree/master

It's quite hard to keep in the loop of all the more niche events / conferences / meetups out there, so hopefully this will help with the slightly niche subject of creating coding / tech.

I've also added a new Events category as I felt it didn't fit under any others, and there's starting to be a few other events lists that could also sit under this.

PR's reviewed: #1676 #1677

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
    • To verify that you've read all the guidelines, please add comment with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@danvoyce danvoyce closed this Nov 8, 2019
@danvoyce danvoyce deleted the patch-2 branch November 8, 2019 16:27
@danvoyce danvoyce restored the patch-2 branch November 8, 2019 16:31
@danvoyce danvoyce changed the title Added new Category events and the list `Awesome Creative Tec… Add Awesome Creative Tech events Nov 8, 2019
@danvoyce danvoyce reopened this Nov 8, 2019
@danvoyce danvoyce changed the title Add Awesome Creative Tech events Add Creative Tech events Nov 8, 2019
@dwmkerr
Copy link

dwmkerr commented Nov 10, 2019

Seems to meet the standards! Needs to be open for 30 days or so I believe but looks OK to me :)

@danvoyce
Copy link
Contributor Author

Seems to meet the standards! Needs to be open for 30 days or so I believe but looks OK to me :)

Does the PR need to be open for 30 days? I thought it was 30 days after the creation of the list?

@dwmkerr
Copy link

dwmkerr commented Nov 12, 2019

Apologies you are quite right, I'd seen the most recent commit on your repo as two days old rather than seeing that the full age of the repo is much older, my mistake!

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@gruhn
Copy link
Contributor

gruhn commented Nov 23, 2019

I ran it through awesome-lint:

✖ Linting

  README.md:97:52
  ✖  97:52  List item description must end with proper punctuation  remark-lint:awesome-list-item

  1 error

I created a PR to your repo to fix this:

danvoyce/awesome-creative-tech-events#3

@gruhn gruhn mentioned this pull request Nov 23, 2019
@danvoyce
Copy link
Contributor Author

Thanks for fixing @gruhn! I'm pretty sure that's the only thing that stopping this from a merge 🤩

@sindresorhus
Copy link
Owner

I'm pretty sure that's the only thing that stopping this from a merge 🤩

It's not. Please read through each guideline.

@Richienb
Copy link
Contributor

Richienb commented Dec 30, 2019

If this list gets its own section, then we should probably move Events in Italy and Events in the Netherlands in the section as well.

@danvoyce
Copy link
Contributor Author

I'm pretty sure that's the only thing that stopping this from a merge 🤩

It's not. Please read through each guideline.

Have reviewed 2 other PR's. Have read through the list again twice. Is there anything else I've missed?

readme.md Outdated Show resolved Hide resolved
readme.md Outdated
@@ -684,3 +685,15 @@

- [Awesome Indexed](https://awesome-indexed.mathew-davies.co.uk) - Search the Awesome dataset.
- [Awesome Search](https://awesomelists.top) - Quick search for Awesome lists.


## Events
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point in adding a category for only one thing. Add it to Misc first and we can consider moving it into a new category later on if there are more similar lists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the misc category, there's Events in Italy and Events in the Netherlands which were added to misc a while ago but since there are now 3 event lists they should now all be under the Events category.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Agree. I think this would also encourage others to create Awesome Lists of Events!

@sindresorhus if you agree shall I make the change as part of this PR?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you agree shall I make the change as part of this PR?

That can be a follow-up PR. It's unrelated to adding your list.

readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Is there anything else I've missed?

Yes:

  • The pull request title is not fully in title-case.
  • Inline comments.
  • Includes a succinct description of the project/theme at the top of the readme.

  • Descriptions of entries in your list should not be in title-case.

Instead of writing just (June), write the full date range.

danvoyce and others added 2 commits January 2, 2020 11:00
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@danvoyce danvoyce changed the title Add Creative Tech events Add Creative Tech Events Jan 3, 2020
@danvoyce
Copy link
Contributor Author

danvoyce commented Jan 3, 2020

  • The pull request title is not fully in title-case.
  • Inline comments.
  • Includes a succinct description of the project/theme at the top of the readme.

It has a description. Would you like it shorter?

  • Descriptions of entries in your list should not be in title-case.

The only part of each entry that is title case is the event or conference name. This has been copied exactly from the associated website, so I feel these should be left as is for consistency and clarity.

  • Instead of writing just (June), write the full date range.

I just put the month as the dates change each year but usually the month stays the same. I feel by just putting the month it should be enough info for most people to click through to learn more, whilst also keeping this more accurate and easier to maintain.

@GustavBertram
Copy link
Contributor

GustavBertram commented Jan 6, 2020

@danvoyce I think you still missed something in the guidelines. I recommend reading them again. The problem is equine in nature.

@danvoyce
Copy link
Contributor Author

@danvoyce I think you still missed something in the guidelines. I recommend reading them again. The problem is equine in nature.

🦄😬

@danvoyce
Copy link
Contributor Author

  • The pull request title is not fully in title-case.
  • Inline comments.
  • Includes a succinct description of the project/theme at the top of the readme.

It has a description. Would you like it shorter?

  • Descriptions of entries in your list should not be in title-case.

The only part of each entry that is title case is the event or conference name. This has been copied exactly from the associated website, so I feel these should be left as is for consistency and clarity.

  • Instead of writing just (June), write the full date range.

I just put the month as the dates change each year but usually the month stays the same. I feel by just putting the month it should be enough info for most people to click through to learn more, whilst also keeping this more accurate and easier to maintain.

@sindresorhus please let me know your thoughts on the above

@danvoyce I think you still missed something in the guidelines. I recommend reading them again. The problem is equine in nature.

🦄😬

unicorn

@danvoyce
Copy link
Contributor Author

  • The pull request title is not fully in title-case.
  • Inline comments.
  • Includes a succinct description of the project/theme at the top of the readme.

It has a description. Would you like it shorter?

  • Descriptions of entries in your list should not be in title-case.

The only part of each entry that is title case is the event or conference name. This has been copied exactly from the associated website, so I feel these should be left as is for consistency and clarity.

  • Instead of writing just (June), write the full date range.

I just put the month as the dates change each year but usually the month stays the same. I feel by just putting the month it should be enough info for most people to click through to learn more, whilst also keeping this more accurate and easier to maintain.

Hi @sindresorhus could you please let me know if you are ok with the above? And if there's anything else. Thanks for your patience :)

@sindresorhus
Copy link
Owner

The only part of each entry that is title case is the event or conference name.

That's not correct:

  • 2 day event about Design, Technology and Cool Shit.

  • Festival for Art, Technology and Society.

and many more. But you could easily have checked this yourself too.


This has been copied exactly from the associated website, so I feel these should be left as is for consistency and clarity.

If the description provided by the associated website is in the correct format and well written sure. If not, it's your job to make it correct, well-written, and "awesome".


I just put the month as the dates change each year but usually the month stays the same. I feel by just putting the month it should be enough info for most people to click through to learn more, whilst also keeping this more accurate and easier to maintain.

👍


The description starts with an uppercase character and ends with a period.

This is also not fully done.

@danvoyce
Copy link
Contributor Author

danvoyce commented Jan 19, 2020

  • add period to end of description
  • Fix title case for each entry

@sindresorhus sindresorhus merged commit 0472352 into sindresorhus:master Jan 21, 2020
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1219502411749842945

@Richienb Richienb mentioned this pull request Jan 29, 2020
DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants